Attention is currently required from: V Sowmya, Martin Roth, Tim Wawrzynczak, Balaji Manigandan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49732 )
Change subject: mb/intel/shadowmountain: Add the ramstage code
......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49732/comment/f8954d12_7b3cbed8
PS6, Line 91: [PchSerialIoIndexGSPI3] = 0,
Since GSPI2 and GSPI3 are disabled, I'd remove the settings for them here
https://review.coreboot.org/c/coreboot/+/49732/comment/0267108b_d5859ca5
PS6, Line 98: [PchSerialIoIndexGSPI3] = 0,
Since GSPI2 and GSPI3 are disabled, I'd remove the settings for them here
https://review.coreboot.org/c/coreboot/+/49732/comment/492ada88_7353f3fc
PS6, Line 148: cr50 TPM
Does shadowmountain have a cr50?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419eecefddf9ee6e4249ada041ebeb1b78e85eb7
Gerrit-Change-Number: 49732
Gerrit-PatchSet: 6
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Mon, 22 Feb 2021 09:00:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment