Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/block: Add Intel common reset code ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... File src/soc/intel/common/block/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... PS7, Line 27: do_force_global_reset
so, do_force_global_reset does not call force_global_reset? ;) this naming is *really* confusing. […]
First we should try to send global reset using CSE command GLOBAL_RESET if failure then we will use PMC global reset enable bit to get guaranteed global reset enforce.
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... PS7, Line 35: global_reset
Why prefer `global_reset` here over `do_global_reset`? Although I will say, the naming here is getti […]
Tim, Prior to send CSE command we need to do some additional work as below hence prefer to have global_reset() call which will eventually redirect to here do_global_reset
vim src/soc/intel/common/reset.c +11
void global_reset(void) { printk(BIOS_INFO, "%s() called!\n", __func__); cf9_reset_prepare(); dcache_clean_all(); do_global_reset(); halt(); }