[coreboot-gerrit] [L] Change in coreboot[main]: soc/intel/xeon_sp: Unshare Xeon-SP chip common codes

[Shuo Liu (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin L Roth, Nico Huber, Patrick Rudolph, Paul Menzel, TangYiwei, Tim Chu.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81312?usp=email )

Change subject: soc/intel/xeon_sp: Unshare Xeon-SP chip common codes
......................................................................

Patch Set 16:

(1 comment)

File src/soc/intel/xeon_sp/chip_gen1.c:

https://review.coreboot.org/c/coreboot/+/81312/comment/dd8b9b5d_ee3c577b :
PS16, Line 192: #if CONFIG(SOC_INTEL_HAS_CXL)
> This wasn't necessary before, is it now?

The original form (as below), cannot get compilation pass after create_cxl_domains is changed to a static function (create_cxl_domains is defined only at #if CONFIG(SOC_INTEL_HAS_CXL)),

if (CONFIG(SOC_INTEL_HAS_CXL) && is_iio_cxl_stack_res(sr))
    create_cxl_domains()

It look like the compiler cannot handle the branch optimization well in this case. Any opinions?