Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )
Change subject: mediatek/mt8183: implement the dramc init setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/dra...
File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/dra...
PS2, Line 23: impedance
If the only goal of this is to allow passing data between dramc_sw_impedance_cal and dramc_sw_impedance_save_reg, I wonder if it is possible to pass that as a struct to make the data flow more explicit?
struct dram_impedance {
u32 data[2][4];
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I756ad37e78cd1384ee0eb97e5e18c5461d73bc7b
Gerrit-Change-Number: 34988
Gerrit-PatchSet: 2
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 23 Aug 2019 07:05:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment