Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35127 )
Change subject: soc/intel/common/acpi/dptf: Add fan based active cooling for TSR sensors
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35127/3/src/soc/intel/common/acpi/d...
File src/soc/intel/common/acpi/dptf/thermal.asl:
https://review.coreboot.org/c/coreboot/+/35127/3/src/soc/intel/common/acpi/d...
PS3, Line 299: #endif
I missed these. Thanks Tim for finding it.
Done
https://review.coreboot.org/c/coreboot/+/35127/5/src/soc/intel/common/acpi/d...
File src/soc/intel/common/acpi/dptf/thermal.asl:
PS5:
That's a good point; I think for Hatch we were only using TSR0/1 but if this is in common code, it s […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I957ae96cf6fa7d2467e73155d64f76a6bd652e31
Gerrit-Change-Number: 35127
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Sep 2019 07:10:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment