Attention is currently required from: Nico Huber, Tim Wawrzynczak, Nick Vaccaro. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 25:
(4 comments)
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/b44814ed_573f309e PS25, Line 171: } };
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/7739cc0d_a3925906 PS25, Line 439: u32 uint32_t
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/93403688_f45c34bf PS24, Line 424:
TYPEC_ORIENTATION_NONE, TYPEC_ORIENTATION_NORMAL, and TYPEC_ORIENTATION_REVERSE are already defined […]
I think you can include coreboot_tables.h directly in chip.h and drop the enum definitions in chip.h. Long term I am thinking we can move this enum definition to src/include/typec.h or something like that. But, we can do that as a follow-up.
https://review.coreboot.org/c/coreboot/+/57069/comment/1433b3cc_f3e7ce59 PS24, Line 443: struct lb_type_c_info { : uint32_t tag; : uint32_t size; : struct type_c_port_info_table_entry type_c_info; : };
lb_type_c_info is needed in conn.c to determine size of cbmem entry.
You can use `struct type_c_info` directly in conn.c to determine size of cbmem entry. You don't need `lb_type_c_info` anymore.