Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60227 )
Change subject: [DO NOT SUBMIT] nb/intel/ironlake: Debugging attempts ......................................................................
Patch Set 1:
(17 comments)
File src/northbridge/intel/ironlake/raminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/326d674b_96d96386 PS1, Line 3079: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/551482fc_3790a483 PS1, Line 3080: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/dfc1a531_0f0468a0 PS1, Line 3081: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/dc0422ae_210a714f PS1, Line 3084: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/1fa491b4_cce3e788 PS1, Line 3091: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/13862554_a2e7e247 PS1, Line 3092: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/fc9680f6_e8b51928 PS1, Line 3093: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/3a16e804_abc23a1b PS1, Line 3096: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/6a910378_2bd65117 PS1, Line 3103: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/87cd3917_6f38db33 PS1, Line 3104: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/a73d920a_e8f68b2e PS1, Line 3105: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/b92c7dba_96899d88 PS1, Line 3108: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/e9367fac_86982f3d PS1, Line 3115: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/51ac47a9_65af078c PS1, Line 3116: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/9085b6e1_42f2978d PS1, Line 3117: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/5dd9036f_48629368 PS1, Line 3120: { Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135841): https://review.coreboot.org/c/coreboot/+/60227/comment/f5e6c034_4f42d520 PS1, Line 3128: if (0)memcpy(&info->training.lane_timings, &lane_timings, sizeof(lane_timings)); trailing statements should be on next line