Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39345 )
Change subject: mb/google/volteer: Enable DPTF functionality ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... PS3, Line 151: Device4Enable
This is not used by TGL SoC code. […]
This is for enabling TCPU as thermal zone.
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... PS3, Line 138: 64000
Shouldn't this match what is in the devicetree?
Ack