Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42257 )
Change subject: soc/intel/*/acpi: Put braces around *else* branch
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42257/2/src/soc/intel/jasperlake/ac...
File src/soc/intel/jasperlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/42257/2/src/soc/intel/jasperlake/ac...
PS2, Line 293: gnvs->chromeos.vbt2 = google_ec_running_ro() ?
: ACTIVE_ECFW_RO : ACTIVE_ECFW_RW;
This is technically one statement. So why the brackets?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb4427f7ae9f7b99ba74f7e84aed6b8a901ca9fc
Gerrit-Change-Number: 42257
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 11 Jun 2020 16:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment