Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33462 )
Change subject: riscv: fix run_payload
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
Thanks!
Please change "riscv: fix run_payload" to something more specific.
Do you have suggest?
Also mention how the change has been tested.
I read this code and found a logic error when setting the MPP field of mstatus.
If you do not return via mret, MPIE will not work.
I have only tested the situation of return to M-Mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaab595f916949c57104ec00f8b06ea047fe76bba
Gerrit-Change-Number: 33462
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Shawn C
citypw@gmail.com
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 20 Jun 2019 09:30:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment