Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39330 )
Change subject: soc/intel/tigerlake: add PcieRpAspm and PchPmPciePllSsc
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39330/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39330/1/src/soc/intel/tigerlake/fsp...
PS1, Line 48: /* Configure Aspm */
: for (int i = 0; i < ARRAY_SIZE(config->PcieRpAspm); i++)
: params->PcieRpAspm[i] = config->PcieRpAspm[i];
:
: /* Configure Spread Spectrum */
: params->PchPmPciePllSsc = config->PchPmPciePllSsc;
There are some follow-up changes that get rid of these. […]
We don't need this change even for ES1. We can use it with FSP default
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3067811b36f45f44527c2c81be74abf2d40addf
Gerrit-Change-Number: 39330
Gerrit-PatchSet: 1
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Wed, 11 Mar 2020 21:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment