Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32725 )
Change subject: Replace ENV_RAMSTAGE with ENV_PAYLOAD_LOADER ......................................................................
Patch Set 6:
(4 comments)
Ok.. I aborted the review midway because I did not exactly understand what this is about.
Nevertheless, I think it's too controversial to merge this before 4.10 is out if you plan to introduce a completely new stage to replace ramstage in your builds.
https://review.coreboot.org/#/c/32725/6/src/arch/x86/cbmem.c File src/arch/x86/cbmem.c:
https://review.coreboot.org/#/c/32725/6/src/arch/x86/cbmem.c@25 PS6, Line 25: if (ENV_PAYLOAD_LOADER && cbmem_top_backup != NULL) ENV_RAMSTAGE was used here because otherwise this creates BSS section for romstage (not allowed for platforms with CAR migration).
https://review.coreboot.org/#/c/32725/6/src/console/init.c File src/console/init.c:
https://review.coreboot.org/#/c/32725/6/src/console/init.c@89 PS6, Line 89: if (CONFIG(EARLY_PCI_BRIDGE) && !ENV_PAYLOAD_LOADER) Nothing to do with payload loader. We don't want SMM console init to mess up PCI bridge configurations. We assume ramstage does not have to redo it (it's called early).
https://review.coreboot.org/#/c/32725/6/src/drivers/elog/elog.c File src/drivers/elog/elog.c:
https://review.coreboot.org/#/c/32725/6/src/drivers/elog/elog.c@863 PS6, Line 863: ramstage_elog_add_boot_count(); Not sure about this, at least the called function name conflicts with the condition you use now, you probably want some elog entry added though.
https://review.coreboot.org/#/c/32725/6/src/drivers/intel/fsp2_0/include/fsp... File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/#/c/32725/6/src/drivers/intel/fsp2_0/include/fsp... PS6, Line 47: #if ENV_PAYLOAD_LOADER Why the guard in the first place?