21 Oct
2020
21 Oct
'20
12:52 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46621 )
Change subject: mb/supermicro/x11-lga1151-series: Follow up GPIO macro changes ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46621/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46621/1/src/mainboard/supermicro/x1... PS1, Line 133: PAD_CFG_GPI_APIC_HIGH(GPP_F5, NONE, PLTRST), I hate these macros. It's barely visible that this adds PAD_CFG1_IOSSTATE_ things that are then defined to 0 based on a Kconfig. Might be ok...
--
To view, visit https://review.coreboot.org/c/coreboot/+/46621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09fd3a107447eb45bb46b7f0f821377943f140b2
Gerrit-Change-Number: 46621
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Oct 2020 09:52:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment