[coreboot-gerrit] Change in coreboot[master]: mainboard/google: Move variant_memory_sku() to baseboard/

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36492 )

Change subject: mainboard/google: Move variant_memory_sku() to baseboard/
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36492/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36492/1//COMMIT_MSG@9 
PS1, Line 9: unreasonably
I would say the assumptions are breaking down from original implementation: memory down and memory strapping pins vs dimms. Does variant_memory_sku() even make sense in the dimm platforms? I would argue not. Are you following up in making it not used in that case? You were already splitting up the spd-in-cbfs case vs spd-on-dimms.