build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38739 )
Change subject: mb/google/dedede: Turn on ESPI device in devicetree ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38739/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38739/1/src/mainboard/google/dedede... PS1, Line 18: /* A1 : ESPI_IO1 ==> ESPI_IO1 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38739/1/src/mainboard/google/dedede... PS1, Line 19: /* A2 : ESPI_IO2 ==> ESPI_IO2 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38739/1/src/mainboard/google/dedede... PS1, Line 20: /* A3 : ESPI_IO3 ==> ESPI_IO3 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38739/1/src/mainboard/google/dedede... PS1, Line 21: /* A4 : ESPI_CS# ==> ESPI_CS_L */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38739/1/src/mainboard/google/dedede... PS1, Line 22: /* A5 : ESPI_CLK ==> ESPI_CLK */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38739/1/src/mainboard/google/dedede... PS1, Line 23: /* A6 : ESPI_RESET_L ==> ESPI_RST_L */ code indent should use tabs where possible