Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31323 )
Change subject: mb/asus/p5ql-em: Add mainboard
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/devicetre...
File src/mainboard/asus/p5ql-em/devicetree.cb:
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/devicetre...
PS4, Line 27:
:
I feel like that would be a good idea if most are the same, but that's not the case.
Ack
https://review.coreboot.org/#/c/31323/5/src/mainboard/asus/p5ql-em/devicetre...
File src/mainboard/asus/p5ql-em/devicetree.cb:
https://review.coreboot.org/#/c/31323/5/src/mainboard/asus/p5ql-em/devicetre...
PS5, Line 162: device pci 1f.4 off end
What's this device?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88fe9c66dae079cd7eedcc9736c5922defbc0e5a
Gerrit-Change-Number: 31323
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 May 2019 13:24:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment
