[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Dump ME f/w version and status information.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )

Change subject: soc/intel/cannonlake: Dump ME f/w version and status information.
......................................................................

Patch Set 6: Code-Review-1

(1 comment)

need to fix this comment

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c 
File src/soc/intel/cannonlake/me.c:

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c@238 
PS6, Line 238: dump_me_status
> One thing to check would be when Heci is disabled. […]

it will give all 0xFFFFF when heci is disable hence the right check should be just before heci gets disable from finalize.c

example: https://github.com/coreboot/coreboot/blob/aa2157430f96c658b9629bf69d507f1f16...