Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30808 )
Change subject: mb/google/sarien/variants/sarien: Set up tcc offset for sarien
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30808/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30808/1//COMMIT_MSG@10
PS1, Line 10: 122636962
please add me in this bug for better understanding. Thanks.
I think that come from the UEFI side. But I think you guys may not need to mention comment1 and bug number in commit summary.
https://review.coreboot.org/#/c/30808/1/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/30808/1/src/mainboard/google/sarien/variants...
PS1, Line 75: 3
How did you arrive to this number ? Is this tested with some scenario ?
I will assume that's same as UEFI
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c5d144e92d1e6e9c81b3e6686805ccf744b7203
Gerrit-Change-Number: 30808
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 05:12:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment