John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47686 )
Change subject: device: Enable ASPM for TBT PCIe root ports ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47686/1/src/device/pciexp_device.c File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/47686/1/src/device/pciexp_device.c@... PS1, Line 449: if ( !cap && (dev->path.type != DEVICE_PATH_GENERIC) )
space prohibited before that close parenthesis ')'
done
https://review.coreboot.org/c/coreboot/+/47686/1/src/device/pciexp_device.c@... PS1, Line 449: if ( !cap && (dev->path.type != DEVICE_PATH_GENERIC) )
space prohibited after that open parenthesis '('
done
https://review.coreboot.org/c/coreboot/+/47686/1/src/device/pciexp_device.c@... PS1, Line 483: if ( (child->path.type != DEVICE_PATH_PCI) &&
space prohibited after that open parenthesis '('
done
https://review.coreboot.org/c/coreboot/+/47686/1/src/device/pciexp_device.c@... PS1, Line 484: (child->path.type != DEVICE_PATH_GENERIC) )
space prohibited before that close parenthesis ')'
done