Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: lib/coreboot_table: Show splashscreen in lb_table_init ......................................................................
Patch Set 11: Code-Review+1
(3 comments)
Just some nits left. Sorry for taking so long.
https://review.coreboot.org/c/coreboot/+/34599/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34599/11//COMMIT_MSG@11 PS11, Line 11: fill_lb_framebuffer call. The period already signifies the end of the sentence, please don't put line breaks after every sentence.
https://review.coreboot.org/c/coreboot/+/34599/11//COMMIT_MSG@24 PS11, Line 24: a white screen - more investigation will be required. What happens with Cirrus VGA in the payload? does the framebuffer work there? if not, the problem is most likely not related to the splashscreen and not worth mentioning here.
https://review.coreboot.org/c/coreboot/+/34599/11/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/34599/11/src/lib/coreboot_table.c@4... PS11, Line 49: No multiple empty lines, please.