Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35173 )
Change subject: soc/skylake: prevent null pointer dereferences ......................................................................
Patch Set 1:
(4 comments)
Note: Since the four comments are about the same thing, marked three of them as resolved so as to keep the conversation on only one of them. If there's anything to change, I will update all four ocurrences, though.
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip.... PS1, Line 156: (dev)
Without parenthesis?
I personally prefer to leave the parentheses around the logical expression, as I find it easier to understand. Not sure if our code style says anything about it, though.
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip.... PS1, Line 217: (dev)
Without parenthesis?
Ack
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip_... File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip_... PS1, Line 357: (dev)
Without parenthesis?
Ack
https://review.coreboot.org/c/coreboot/+/35173/1/src/soc/intel/skylake/chip_... PS1, Line 433: (dev)
Without parenthesis?
Ack