Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34476 )
Change subject: Rampayload: Attempt to boot coreboot without ramstage ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34476/2/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34476/2/Makefile.inc@255 PS2, Line 255: ifeq ($(CONFIG_RAMPAYLOAD),y)
Is there no way to use ENV_PAYLOAD_LOADER here somehow? […]
i don't think ENV_PAYLOAD_LOADER macro will able to tell us what is the stage name.
https://review.coreboot.org/c/coreboot/+/34476/2/src/cpu/x86/smm/Makefile.in... File src/cpu/x86/smm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34476/2/src/cpu/x86/smm/Makefile.in... PS2, Line 16: ifeq ($(CONFIG_HAVE_RAMSTAGE),y)
This is a very similar conditional to the one in the IASL, is there now way to create an over-archin […]
Done
https://review.coreboot.org/c/coreboot/+/34476/2/src/lib/program.ld File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/34476/2/src/lib/program.ld@58 PS2, Line 58: #if ENV_PAYLOAD_LOADER
oh dear. How many of these pci drivers are we using and why? I had hoped to avoid this. […]
we will try to avoid this. removing now, let see later
https://review.coreboot.org/c/coreboot/+/34476/2/src/mainboard/google/dragon... File src/mainboard/google/dragonegg/chromeos.c:
https://review.coreboot.org/c/coreboot/+/34476/2/src/mainboard/google/dragon... PS2, Line 24: #if ENV_PAYLOAD_LOADER
why do we need this? I thought we'd agreed that for now chromebooks and similar devices were not goi […]
if we plan to not support chrome device then we don't need this now
https://review.coreboot.org/c/coreboot/+/34476/2/src/mainboard/intel/icelake... File src/mainboard/intel/icelake_rvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/34476/2/src/mainboard/intel/icelake... PS2, Line 23: #if ENV_PAYLOAD_LOADER
same question. If you are doing this just to get it all to build, let's take another look. If you need it for real reasons, I'm wondering what those reasons are?
removing now.
Also, for SMM, given that I'm working on several "SMM MUST DIE" projects; can we just have the kernel do the SMM and not set it up in coreboot?
this is interesting