hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32057 )
Change subject: mediatek/mt8183: Calibrate vsim2 to 2.7 V
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/32057/7/src/soc/mediatek/mt8183/include/soc/...
File src/soc/mediatek/mt8183/include/soc/mt6358.h:
https://review.coreboot.org/#/c/32057/7/src/soc/mediatek/mt8183/include/soc/...
PS7, Line 42: void pmic_set_vsim2_cali(void);
I still have no idea what this does and which boards would need it vs which don't. […]
Hi Julius,
I update the comment message. Are there any other things that need to be clarified?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dffdde89cbde91286d92e6c2b445f0b3d0ad2fe
Gerrit-Change-Number: 32057
Gerrit-PatchSet: 8
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Jun 2019 03:21:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment