Nicola Corna has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31470 )
Change subject: ec/lenovo/h8/acpi: Add alternative Fn-F2 and Fn-F3 layout
......................................................................
Patch Set 2:
Patch Set 1:
https://review.coreboot.org/c/coreboot/+/31067 also has issues with event mapping.
I guess the best would be to move all of the _Q* methods to shared files and include those based on the EC revision / mainboard variant.
The changes of this patch and of 31067 on ec.asl are quite minimal, I'm not sure if duplicating the whole _Qxx mapping on separate files is the right solution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2d96be1a7815d7d03e6e8c6d300fd671c8598ca
Gerrit-Change-Number: 31470
Gerrit-PatchSet: 2
Gerrit-Owner: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Apr 2019 08:40:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment