Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32014 )
Change subject: soc/{amd,intel}/chip: Use local include for chip.h
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32014/6/src/soc/intel/braswell/include/soc/r...
File src/soc/intel/braswell/include/soc/ramstage.h:
https://review.coreboot.org/#/c/32014/6/src/soc/intel/braswell/include/soc/r...
PS6, Line 23: #include "../../chip.h"
You could also use a more qualified path for these cases
#include <soc/intel/braswell/chip.h>
your call
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fcbf4b54b7d0b5cda04ca9f7fc145050c867b8
Gerrit-Change-Number: 32014
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Apr 2019 11:47:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment