build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29481 )
Change subject: [RFC] lib/spd_bin: Redesign API ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h File src/include/spd_bin.h:
https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h@92 PS2, Line 92: ssize_t gather_spds(struct spd_binfo *); function definition argument 'struct spd_binfo *' should also have an identifier name
https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h@94 PS2, Line 94: void dump_spd_info(const struct spd_binfo *); function definition argument 'const struct spd_binfo *' should also have an identifier name
https://review.coreboot.org/#/c/29481/2/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/#/c/29481/2/src/lib/spd_bin.c@227 PS2, Line 227: if (common_len == -1) { braces {} are not necessary for any arm of this statement