Hello Julius Werner, Duncan Laurie, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31706
to look at the new patch set (#4).
Change subject: cbfstool: Change FMD annotation to flags ......................................................................
cbfstool: Change FMD annotation to flags
The idea of "annotation" for firmware sections was pretty flexible, but in future we will want multiple attributes applied to same area. For example, indicate the section must be preserved when updating firmware so serial number or MAC address can be preserved.
The solution here is to extend annotation so it can take multiple identifiers (flags) in a row. For example, to declare a 64KB COREBOOT section as CBFS using annotation:
COREBOOT(CBFS)@0x0 64k
If there's a new flag "PRESERVE" indicating the section must be preserved before update, we can declare it following CBFS flag:
COREBOOT(CBFS PRESERVE)@0x0 64k
The flags are directly parsed in fmd_parser, and stored in an union flashmap_flags. Output modules can choose to ignore or process the flags.
Currently the only supported flag is "CBFS" (for backward compatible with annotation). There will be more new flags in follow up patches.
BUG=chromium:936768 TEST=make; boots an x86 image.
Change-Id: Ie2d99f570e6faff6ed3a4344d6af7526a4515fae Signed-off-by: Hung-Te Lin hungte@chromium.org --- M util/cbfstool/README.fmaptool M util/cbfstool/cbfs_sections.c M util/cbfstool/fmd.h M util/cbfstool/fmd_parser.c_shipped M util/cbfstool/fmd_parser.h_shipped M util/cbfstool/fmd_parser.y M util/cbfstool/fmd_scanner.c_shipped M util/cbfstool/fmd_scanner.h_shipped M util/cbfstool/fmd_scanner.l 9 files changed, 365 insertions(+), 321 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/31706/4