Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35064 )
Change subject: mb/facebook/fbg1701/devicetree.cb: Use 64MB framebuffer size
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35064/1/src/mainboard/facebook/fbg1...
File src/mainboard/facebook/fbg1701/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35064/1/src/mainboard/facebook/fbg1...
PS1, Line 12: register "PcdIgdDvmt50PreAlloc" = "2"
Add a comment, that this is 64 MB?
It would be nice to have some macros giving some meaning to these values. baytrail fsp calls them IGD_MEMSIZE_xMB
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25d2cd696830fc5bda84ea2b87538f526373998e
Gerrit-Change-Number: 35064
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Sep 2019 15:55:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment