[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add northbridge pci driver

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )

Change subject: soc/amd/picasso: Add northbridge pci driver
......................................................................

Patch Set 31:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
PS31, Line 41: for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
> Thanks Raul. […]

Here is the memory map I came up with after dumping the GUIDS:

0x0000000230000000 (8960 MB) - TOM2
+ 12 MiB - Unknown reserved memory
0x000000022f340000 (8947 MB) - SYSTEM_MEMORY_TOP_HIGH
+ 4851.25 MiB - DRAM
0x0000000100000000 (4096 MB) - 4 GiB boundry

+ 18 MiB - MMIO
0x00000000fedd5800 (4077 MB)
+ 854 KiB - FCH (GPIO/UART/I2C/...)
0x00000000fed00000 (4077 MB)
+ 895 KiB - MMIO
0x00000000fec200ac (4076 MB)
+ 128 KiB - IOAPIC / SPI / eSPI
0x00000000fec00000 (4076 MB)
+ 44 MiB - MMIO
0x00000000fc000000 (4032 MB)
+ 64 MiB - PCIe enhanced config space
0x00000000f8000000 (3968 MB)
+ 640 MiB - MMIO

0x00000000d0000000 (3328 MiB) - TOM1
+ 32 MiB - Guessing Chipset reserved DRAM
0x00000000ce000000 (3296 MB) - SYSTEM_MEMORY_TOP_LOW
+ 8 MiB - TSEG
0x00000000cd800000 (3288 MB) - cbmem_top / BOOTLOADER_TOLUM_END
+ 8 KiB - CBMEM metadata
0x00000000cd7fe000 (3287 MB) - BOOTLOADER_TOLUM_START
+ 16 MiB - FSP Reserved Memory
0x00000000cc7fe000 (3271 MB) - FSP Reserved Memory
+ 3254 MiB - DRAM
0x0000000001140000 (17 MB)
+704 KiB - FSP-M - https://chrome-internal-review.googlesource.com/c/chromeos/third_party/amd-f...
0x0000000001090000 (16 MB)
+ 16.5MiB - DRAM
0x0000000000000000 (0 MB)

Here is the raw data:
Adding PCIe enhanced config space BAR 0xf8000000-0xfc000000.
TOM1: 0x00000000d0000000
TOM2: 0x0000000230000000

read_resources: SYSTEM_MEMORY:
        addr: 0x0000000000000000 (0 MB)
        length: 3456106496 (3296 MB)
        end: 0x00000000ce000000 (3296 MB)
        Owner GUID: 00000000-0000-0000-0000000000000000
        No GUID specified
Skipping, below mem_usable: 0x00000000cd800000

read_resources: RESERVED_MEMORY: <- Chipset reserved DRAM?
        addr: 0x00000000ce000000 (3296 MB) <- System Memory Top Lower
        length: 33554432 (32 MB)
        end: 0x00000000d0000000 (3328 MB) <-- TOM1
        Owner GUID: 00000000-0000-0000-0000000000000000
        No GUID specified

read_resources: SYSTEM_MEMORY:
        addr: 0x0000000100000000 (4096 MB)
        length: 5086904320 (4851 MB)
        end: 0x000000022f340000 (8947 MB) <- System Memory Top High
        Owner GUID: 00000000-0000-0000-0000000000000000
        No GUID specified

read_resources: RESERVED_MEMORY:
        addr: 0x000000022f340000 (8947 MB) <- System Memory Top High
        length: 13369344 (12 MB)
        end: 0x0000000230000000 (8960 MB) <- TOM2
        Owner GUID: 00000000-0000-0000-0000000000000000
        No GUID specified

read_resources: RESERVED_MEMORY:
        addr: 0x00000000cd800000 (3288 MB) - BOOTLOADER_TOLUM_END
        length: 8388608 (8 MB)
        end: 0x00000000ce000000 (3296 MB)
        Owner GUID: 5fc7897a-5aff-4c61-aa7addcfa918430c <- gAmdFspTsegHobGuid
        Unknown GUID

read_resources: RESERVED_MEMORY:
        addr: 0x00000000cd7fe000 (3287 MB) - BOOTLOADER_TOLUM_START
        length: 8192 (0 MB)
        end: 0x00000000cd800000 (3288 MB) - BOOTLOADER_TOLUM_END
        Owner GUID: 73ff4f56-aa8e-4451-b31636353667ad44 <- fsp_bootloader_tolum_guid
        BOOTLOADER_TOLUM

read_resources: RESERVED_MEMORY:
        addr: 0x00000000cc7fe000 (3271 MB)
        length: 16777216 (16 MB)
        end: 0x00000000cd7fe000 (3287 MB) - BOOTLOADER_TOLUM_START
        Owner GUID: 69a79759-1373-4367-a6c4c7f59efd986e <- fsp_reserved_memory_guid
        FSP_RESERVED_MEMORY
read_resources: RESERVED_MEMORY:
        addr: 0x0000000001090000 (16 MB)
        length: 720896 (0 MB)
        end: 0x0000000001140000 (17 MB)
        Owner GUID: 00000000-0000-0000-0000000000000000
        No GUID specified

I think everything looks correct and as expected. Do you see anything that needs changing?