Attention is currently required from: Andrey Pronin, Christian Walter, Eric Lai, Erik van den Bogaert, Felix Held, Frans Hendriks, Fred Reitberger, Jason Glenesk, Julius Werner, Karthik Ramasubramanian, Martin L Roth, Matt DeVillier, Nick Vaccaro, Subrata Banik, Tim Van Patten, Yu-Ping Wu.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77666?usp=email )
Change subject: treewide: convert to tpm_result_t
......................................................................
Patch Set 28:
(5 comments)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/77666/comment/695abc61_88db69c2 :
PS27, Line 277: if(rc)
`space required before the open parenthesis '('`
Please fix.
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/77666/comment/3e461e94_dcbcb6c2 :
PS27, Line 226: error(0x%x)
nit: `error (%#x)`
Done
https://review.coreboot.org/c/coreboot/+/77666/comment/69e7f76f_10698d38 :
PS27, Line 374: tpm_rc);
No matter what style you choose, the indentation level should be the same as `VB2_RECOVERY_RO_TPM_U_ […]
Done
https://review.coreboot.org/c/coreboot/+/77666/comment/b145e2ac_ef28b67a :
PS27, Line 384: %x
Let's take the chance to change it to `%#x`?
Done
https://review.coreboot.org/c/coreboot/+/77666/comment/51dbca50_3a52b552 :
PS27, Line 394: %x
Let's take the chance to change it to `%#x`?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77666?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifdf9ff6c2a1f9b938dbb04d245799391115eb6b1
Gerrit-Change-Number: 77666
Gerrit-PatchSet: 28
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 27 Sep 2023 04:08:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment