Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34588 )
Change subject: util/inteltool: Add Intel HD 4400 (Haswell IGD)
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34588/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34588/3//COMMIT_MSG@9
PS3, Line 9: Add the 8086:041e integrated graphics controller to the list of
: definitions.
: Adding the definition makes the Intel HD 4400 graphics recognized by inteltool.
Please use the same text-width, and add a blank line between paragraphs.
Done
https://review.coreboot.org/c/coreboot/+/34588/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34588/4//COMMIT_MSG@10
PS4, Line 10: Adding the definition makes the Intel HD 4400 graphics recognized by inteltool.
Close, but the usual line-length limit is 72 chars (absolute maximum for […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d6b2eaa7cc5aa3912592ed3fcb73751b224eede
Gerrit-Change-Number: 34588
Gerrit-PatchSet: 7
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Sep 2019 12:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment