Attention is currently required from: Marshall Dawson, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42563 )
Change subject: [RFC] AMD APM_CNT and SMI enablement
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/42563/comment/9f1e7f32_58188a83
PS1, Line 244: pm_write16(PM_GPE0_BLK, ACPI_GPE0_BLK);
Now that I revisit this, PM1 and GPE0 sound like something chipset_power_state would need to eg. […]
without having looked into that, this sounds like a bug to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42563
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d1287566061bc5d6f05e687f2b30c6bcb66c999
Gerrit-Change-Number: 42563
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 14 Feb 2021 22:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment