Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40322 )
Change subject: soc/amd/picasso: Cleanup legacy UART config
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40322/2/src/soc/amd/picasso/Kconfig...
PS2, Line 169: uart
UART
Does it need a prompt?
And why is this configured in Kconfig and not the devicetree (where resources
usually are)? What is done to avoid resource conflicts? e.g. for a board with
super-i/o and a UART at 0x2e8, one could accidentally select the same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40322
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id08ff6428d4019303ebb6e44e13aba480cf1fde2
Gerrit-Change-Number: 40322
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 13 Apr 2020 14:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment