22 Nov
2018
22 Nov
'18
3 p.m.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29687 )
Change subject: drivers/intel/fsp1_1/cache_as_ram.inc: Dont include soc/car_setup.S ......................................................................
Patch Set 1:
Patch Set 1:
remove in src/drivers/intel/fsp1_1/after_raminit.S as well?
No. In this file the function chipset_teardown_car() is called. This function is available, so might cause malfunction.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29687
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebae2940eb10c9ca9054437be4740c79137bcc61
Gerrit-Change-Number: 29687
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy leroy.p.leahy@intel.com
Gerrit-Reviewer: York Yang york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Thu, 22 Nov 2018 15:00:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment