Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44196/7/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/44196/7/src/drivers/mrc_cache/mrc_c... PS7, Line 668: #if CONFIG(MRC_WRITE_NV_LATE)
Yes, it was discussed. Here's your comment: […]
No, but that doesn't discuss which boot state the new finalize is executing in? All I'm saying is you might get away with just writing this as
BOOT_STATE_INIT_ENTRY(BS_DEV_ENUMERATE, BS_ON_EXIT, finalize_mrc_cache, NULL);
without the #if to make it simpler. That depends on whether the non-NV_LATE platforms have any restrictions on when exactly the flash protection needs to happen in ramstage. Furquan can probably chime in on this.