Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36462 )
Change subject: soc/intel/{cnl,icl,skl}: Remove unused SMI opregion ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36462/1/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/36462/1/src/soc/intel/skylake/acpi/... PS1, Line 38: /* IO-Trap at 0x800. : * This is the ACPI->SMI communication interface. : */ : OperationRegion (IO_T, SystemIO, 0x800, 0x10) : Field (IO_T, ByteAcc, NoLock, Preserve) : { : Offset (0x8), : TRP0, 8 /* IO-Trap at 0x808 */ : }
I haven't checked but I don't think any platform in master has an io trap smihandler. […]
yes should be good to clean as well
https://review.coreboot.org/c/coreboot/+/36462/1/src/soc/intel/skylake/acpi/... PS1, Line 49: TRAP
This is needed somewhere in drivers/intel/gma , but it's no-op. […]
may be i will check with GFX team if they have any question, but in general good to clean both in specific CLs as these are more debug hooks