Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48317 )
Change subject: soc/amd/cezanne: add config.c and minimal chip.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48317/1/src/soc/amd/cezanne/config.... File src/soc/amd/cezanne/config.c:
https://review.coreboot.org/c/coreboot/+/48317/1/src/soc/amd/cezanne/config.... PS1, Line 9: cfg It looks like the soc_get_config() return value is typically checked for non-0. But we'll always return non-0 due to line 10. Should probably be
const struct soc_amd_cezanne_config *cfg = config_of_soc(); if (!cfg) return NULL; return &cfg->common_config;
Maybe fix it in picasso first, then add a consistent function to cezanne.