Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46306 )
Change subject: soc/intel/xeon_sp/skx: Add resource allocator helpers ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46306/4/src/soc/intel/xeon_sp/skx/c... File src/soc/intel/xeon_sp/skx/chip.c:
https://review.coreboot.org/c/coreboot/+/46306/4/src/soc/intel/xeon_sp/skx/c... PS4, Line 364: brigge
typo
Done
https://review.coreboot.org/c/coreboot/+/46306/4/src/soc/intel/xeon_sp/skx/c... PS4, Line 356: ResType res_types[MAX_RES_TYPES] = { : RES_TYPE_IO, : RES_TYPE_NONPREF_MEM, : RES_TYPE_PREF_MEM : }; : : uint8_t no_res_types = MAX_RES_TYPES; : : /* if it is a bridge, only process matching brigge resource type */ : if (bridge) { : res_types[0] = get_res_type(bridge->flags); : no_res_types = 1; : } : : printk(BIOS_DEBUG, "%s:%d no_res_types: %d\n", __func__, __LINE__, : no_res_types); : : /* Process each resource type */ : for (int rt = 0; rt < no_res_types; ++rt) { : struct stack_dev_resource *res_root = NULL; : printk(BIOS_DEBUG, "%s:%d rt: %d\n", __func__, __LINE__, rt); : for (curdev = bus->children; curdev; curdev = curdev->sibling) { : struct resource *res; : printk(BIOS_DEBUG, "%s:%d dev: %s\n", : __func__, __LINE__, dev_path(curdev)); : if (!curdev->enabled) : continue; : : for (res = curdev->resource_list; res; res = res->next) { : printk(BIOS_DEBUG, "%s:%d dev: %s, flags: 0x%lx\n", : __func__, __LINE__, : dev_path(curdev), res->flags); : if (res->size == 0 || : get_res_type(res->flags) != res_types[rt] || : (res->flags & IORESOURCE_BRIDGE) || : !need_assignment(res->flags))
IORESOURCE_PCI64 is an attribute of IORESOURCE_IO/MEM. […]
Ack