Attention is currently required from: Nico Huber, Martin Roth, Matt DeVillier, Stefan Reinauer, Angel Pons, Andrey Petrov, Patrick Rudolph.
Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53934 )
Change subject: payload/external/tianocore/Kconfig: Toggle default payload
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Why show the CorebootPayloadPkg option at all if it is known […]
Good point. Lacking the technical detail knowledge here, I would have argued that maybe someone who tries to develop on the CorebootPayloadPkg ('s compatibility) could toggle it.
Taking into account Matt DeVillier's post, I guess this whole discussion is more or less obsolete now.
From my side I just wanted to fix a default faulty behavior. As I, lacking the technical detail (call me DAU on this one), wasted a bit of time trying to figuring out why CorebootPayloadPkg did not work.
PS5:
now that it's mature enough, seems to me that the better solution would be for me to push a patch th […]
I agree. See my answer to Nico's comment.
Will the `uefipayloadpkg` support Apollo/Gemini Lake machines?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib50fdaf2cd5c599e497ef8ca06e5692a9e69b813
Gerrit-Change-Number: 53934
Gerrit-PatchSet: 5
Gerrit-Owner: Patrik Tesarik
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 08 May 2021 14:40:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment