Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37906 )
Change subject: mb/google/octopus: Add two new sku IDs for foob
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37906/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/37906/2/src/mainboard/google/octopu...
PS2, Line 33: google_chromeec_cbi_get_sku_id(&sku_id);
This is another place for using get_board_sku()? On the other hand, if no_touchscreen_sku() always needs sku_id then you can just put "sku_id = get_board_sku()" inside this function? But this is not the strong opinion so even if just change to use get_board_sku() here is fine. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffcbb3f6f945ea299ff687a383a82b88dcd11ea1
Gerrit-Change-Number: 37906
Gerrit-PatchSet: 2
Gerrit-Owner: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Thu, 26 Dec 2019 05:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment