Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46385 )
Change subject: HACK: mt8192: Add SPI support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46385/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/bootblock.c:
https://review.coreboot.org/c/coreboot/+/46385/1/src/mainboard/google/asurad... PS1, Line 10: //
please uncomment this - I think we have enough drivers for enabling eint?
This line is replaced by gpio_eint_configure(GPIO_H1_AP_INT, IRQ_TYPE_EDGE_RISING);
and GPIO_H1_AP_INT is defined in next patch (mb/google/asurada: Add Chrome OS GPIOs)
I will simply remove this line.