Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46134 )
Change subject: sb/intel/lynxpoint: Set PCIe L1 substates capabilities register
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46134/2/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/46134/2/src/southbridge/intel/lynxp...
PS2, Line 681: /* Set L1 Sub-State Cap ID to 1Eh and Next Cap Pointer to None. */
my preference would be to keep as-is for consistency, unless the comment was incorrect or unclear, a […]
I'd rather keep it where it is
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2ae3d9539de9f7e22975f00450d9d60d1fd938a
Gerrit-Change-Number: 46134
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 09:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment