Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31086 )
Change subject: payloads/ipxe: Enable HTTPS support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31086/3/payloads/external/iPXE/Makefile
File payloads/external/iPXE/Makefile:
https://review.coreboot.org/#/c/31086/3/payloads/external/iPXE/Makefile@57
PS3, Line 57: sed -ie 's|.*DOWNLOAD_PROTO_HTTPS|#define DOWNLOAD_PROTO_HTTPS|g' "$(project_dir)/src/config/general.h"
Standard sed doesn't know -i, and this doesn't work with GNU […]
Ah, that about GNU sed wasn't right. It creates
a backup file with the suffix `e`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia25d4ce9260fa8c00fdea0e19f5e927559371af0
Gerrit-Change-Number: 31086
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 05 May 2019 13:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment