Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46434 )
Change subject: mrc_cache: Add TPM Hash verification ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46434/8/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46434/8/src/drivers/mrc_cache/Kconf... PS8, Line 52: MRC_SAVE_MRC_HASH
MRC twice? (I would consider MRC_SAVE_TPM_HASH or MRC_SAVE_HASH_IN_TPM, otherwise it's not very clea […]
renamed to MRC_SAVE_HASH_IN_TPM
https://review.coreboot.org/c/coreboot/+/46434/8/src/drivers/mrc_cache/Kconf... PS8, Line 57: object
When I said "missing object", I meant "this sentence is missing its (grammatical) object" (i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/46434/2/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46434/2/src/drivers/mrc_cache/mrc_c... PS2, Line 377: int type
We need to be careful about the type here. The RW vs. […]
Done. Added !MRC_SETTINGS_VARIABLE_DATA dependency to mrc_cache Kconfig.
https://review.coreboot.org/c/coreboot/+/46434/2/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46434/2/src/security/vboot/Makefile... PS2, Line 96: bootblock-$(CONFIG_SAVE_MRC_HASH) += mrc_cache_hash_tpm.c
nit: really only needs romstage and ramstage.
Done