27 Mar
2018
27 Mar
'18
10:44 p.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/25389 )
Change subject: mb/google/poppy: Add variant for Atlas ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25389/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/#/c/25389/1/src/mainboard/google/poppy/variants/... PS1, Line 8: DSX_EN_WAKE_PIN
Right. We would need to route to a different pin for S0ix.
It looks like WAKE# is still used but the PE_RST was moved to GPP_B8? The bug does suggest we need to move wake as well. (don't want to link to an internal bug here)
--
To view, visit https://review.coreboot.org/25389
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0bccd1bda0134aa51885ac2c6e7bb5b45de924
Gerrit-Change-Number: 25389
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Caveh Jalali caveh@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 27 Mar 2018 22:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No