Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33233 )
Change subject: soc/intel/cannonlake: Add _DSM method for SD controller ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/33233/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33233/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/cannonlake: Add _DSM method for SD controller
Can we get a better description here also? That the _DSM method is adding sleeps to voltage level s […]
Done
https://review.coreboot.org/#/c/33233/1//COMMIT_MSG@8 PS1, Line 8:
Can you please add the BUG= field.
Done
https://review.coreboot.org/#/c/33233/1/src/soc/intel/cannonlake/acpi/scs.as... File src/soc/intel/cannonlake/acpi/scs.asl:
https://review.coreboot.org/#/c/33233/1/src/soc/intel/cannonlake/acpi/scs.as... PS1, Line 106: (
Please use space before ( here and in rest of the uses in this file.
Done
https://review.coreboot.org/#/c/33233/1/src/soc/intel/cannonlake/acpi/scs.as... PS1, Line 106: ToUUID("f6c13ea5-65cd-461f-ab7a-29f7e8d5bd61")
Not a big deal, but it would be easier to read through if this was a Name(UUID, ToUUID(... […]
Done
https://review.coreboot.org/#/c/33233/1/src/soc/intel/cannonlake/acpi/scs.as... PS1, Line 131: /* : * Function Index 3: Set 1.8v signalling. : * We put a sleep of 100ms in this method to : * work around a known issue with detecting : * UHS SD card on PCH. This is to compensate : * for the SD VR slowness. : */ : Case(3) { : Sleep (100) // Sleep 100ms : Return(Buffer(){0x00}) : } : /* : * Function Index 4: Set 3.3v signalling. : * We put a sleep of 100ms in this method to : * work around a known issue with detecting : * UHS SD card on PCH. This is to compensate : * for the SD VR slowness. : */ : Case(4) { : Sleep (100) // Sleep 100ms : Return(Buffer(){0x00}) : }
Are these issues documented somewhere?
Not that I know of.