Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45713 )
Change subject: sb/intel/lynxpoint/pcie.c: Fix subtle blunder ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45713/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45713/1//COMMIT_MSG@7 PS1, Line 7: sb/intel/lynxpoint/pcie.c: Fix subtle blunder
Mind providing ideas, please? I think this would qualify as a "subtle blunder". […]
Please just rewrite both, e.g.
sb/intel/lynxpoint/pcie: Fix clock gating routine
The use of `1 < 5` as a bit mask was obviously a typo. Fix it to `1 << 5`.
https://review.coreboot.org/c/coreboot/+/45713/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/45713/2/src/southbridge/intel/lynxp... PS2, Line 286: pci_or_config8(dev, 0x324, 1 << 5);
is it intended that this is not doing the same as line 287? ((1 < 5) vs (1 << 5))
If it wasn't changing anything, the commit message would be a lie ;)