Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45373 )
Change subject: soc/intel/common/block: Do not die if PRMRR size unsupported
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45373/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45373/1//COMMIT_MSG@10
PS1, Line 10: We don't do that when PRMRRs aren't even supported anyway.
Reviewers, if you believe these lines are charged with too much frustration, feel free to suggest so […]
I don't quite get the statement, tbh. We don't brick when it's
unsupported, so shouldn't brick if it is?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45373
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib917be873aedbc5e789bb0894fca335b5ee9e2c2
Gerrit-Change-Number: 45373
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Sep 2020 20:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment