Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Arthur Heymans, Lean Sheng Tan, Andrey Petrov.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63166 )
Change subject: drivers/intel/fsp2_0: Allow coreboot to control FSP serial redirection
......................................................................
Patch Set 1:
(5 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/63166/comment/0c977b7a_27cdbc7f
PS1, Line 362: HAVE_FSP_DEBUG
Maybe: `FSP_ENABLE_SERIAL_DEBUG`
https://review.coreboot.org/c/coreboot/+/63166/comment/eee53c04_16142594
PS1, Line 363: Have FSP debug binaries to get the console output
Maybe: Output FSP debug messages on serial console
https://review.coreboot.org/c/coreboot/+/63166/comment/2c8701ac_398428a1
PS1, Line 370: Select this option from site-local
Why site-local?
https://review.coreboot.org/c/coreboot/+/63166/comment/7e19130d_9b53b2a1
PS1, Line 371: serial debug
Without “debug”?
https://review.coreboot.org/c/coreboot/+/63166/comment/41d935b6_04b1dfa8
PS1, Line 372: binaries.
What happens, when you have non-FSP debug builds? Is there an error, or just no messages are send to serial console?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b008ca9d4f40bfa6a989a6fd655c234f91fde65
Gerrit-Change-Number: 63166
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 13:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment