Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34130 )
Change subject: soc/intel/cannonlake: Enable FSP to use coreboot stack
......................................................................
Patch Set 1:
(1 comment)
Is this tested on CFL, CNL, WHL and CML? What happens if you
use a FSP2.0 binary with this?
https://review.coreboot.org/c/coreboot/+/34130/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34130/1//COMMIT_MSG@9
PS1, Line 9: v1263
Can you explain this versioning scheme to me? The FSP on Github uses
very different numbers. When will this v1263 be publicly available?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4098a4374363ca6f3c86c396d097f9eabc9a28fe
Gerrit-Change-Number: 34130
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 08 Jul 2019 07:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment